Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new builder pattern for serializing tables and unions #155

Merged
merged 10 commits into from
Dec 3, 2022
Merged

Implement new builder pattern for serializing tables and unions #155

merged 10 commits into from
Dec 3, 2022

Conversation

TethysSvensson
Copy link
Collaborator

@TethysSvensson TethysSvensson commented Dec 3, 2022 •
edited
Loading

Checklist

  • Updated CHANGELOG.md with relevant changes
  • Added tests for any new/fixed functionality
  • Added/updated documentation for new/changed code
  • Checked that README.md still makes sense (and updated it if necessary)

@TethysSvensson TethysSvensson changed the title Tethys/builders Implement new builder pattern for serializing tables and unions Dec 3, 2022
@TethysSvensson
Copy link
Collaborator Author

We are missing a few tests, this will be done in a follow-up PR. Added #156 to keep track of it.

@kristoff3r kristoff3r self-requested a review December 3, 2022 16:29
@TethysSvensson TethysSvensson enabled auto-merge (squash) December 3, 2022 16:30
@TethysSvensson TethysSvensson enabled auto-merge (squash) December 3, 2022 16:31
@TethysSvensson TethysSvensson merged commit 1835799 into main Dec 3, 2022
@TethysSvensson TethysSvensson deleted the tethys/builders branch December 3, 2022 16:35
@TethysSvensson TethysSvensson mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TethysSvensson @kristoff3r